Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: remove unneeded return statement #48526

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jun 22, 2023

The writable._write() implementation does not need to return anything, only call the callback.

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 22, 2023
The `writable._write()` implementation does not need to return anything,
only call the callback.
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 22, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit d09ff0d into nodejs:main Jun 26, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d09ff0d

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
The `writable._write()` implementation does not need to return anything,
only call the callback.

PR-URL: #48526
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
The `writable._write()` implementation does not need to return anything,
only call the callback.

PR-URL: nodejs#48526
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
The `writable._write()` implementation does not need to return anything,
only call the callback.

PR-URL: nodejs#48526
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@lpinca lpinca deleted the remove/return-statement branch September 6, 2023 12:45
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
The `writable._write()` implementation does not need to return anything,
only call the callback.

PR-URL: #48526
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 10, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
The `writable._write()` implementation does not need to return anything,
only call the callback.

PR-URL: #48526
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants